Changes between Version 1 and Version 5 of Ticket #6543


Ignore:
Timestamp:
05/10/2018 01:54:21 PM (21 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6543

    • Property Status changed from reviewing to closed
    • Property Cc greiner added
    • Property Resolution changed from to fixed
    • Property Milestone changed from to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Ticket #6543 – Description

    v1 v5  
    44=== What to change === 
    55Fall back to `originUrl` on Firefox, and `initiator` on Chrome, when either the `tabId` or `frameId` is set to `-1`. So that the `$domain` filter option as well as document-based whitelisting (including `$sitekey`) work for requests sent from Service Workers (and other scenarios where no tab is associated). 
     6 
     7=== Hints for testers === 
     8 
     9Make sure that requests sent by Service Workers (e.g. on https://regex101.com/) show up in the "Adblock Plus" devtools panel (for the correct tab only), and are subject to request blocking (with `$domain` option) and `$document` exception rules applied to the document that caused the worker to spawn. Requests sent by Service Workers are indicated with a gear icon in the (built-in) "Network" panel in the devtools. 
     10 
     11Note that this change involved a refactoring of large parts of the request blocking and whitelisting logic, so watch out for potential regressions (which might not directly relate to the Service Worker scenario).