Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#6546 closed change (fixed)

[CMS] Default template in the test suite should not be empty

Reported by: kvas Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: rhowell, jsonesen, snoack Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29741581/

Description

Background

The default template of our test suite is called default.tmpl and is empty. Another template is available, which essentially copies the content of the page into the output. It's called empty.tmpl. Most pages of the test suite select empty.tmpl explicitly to produce some output (with default.tmpl the output would be empty).

While this works as is, the situation is also quite confusing. The expectation would be that empty.tmpl contains nothing and default.tmpl copies the page to the output. Another, possibly greater problem is that it's not possible to have a page without metadata that produces output.

What to change

Swap the contents of default.tmpl and empty.tmpl and adjust the use of the templates by the test pages so that the output won't change.

Change History (3)

comment:2 Changed 21 months ago by kvas

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:3 Changed 21 months ago by kvas

  • Component changed from Unknown to Sitescripts
Note: See TracTickets for help on using tickets.