Opened 18 months ago

Closed 3 weeks ago

Last modified 31 hours ago

#6551 closed change (rejected)

Provide ability to specify alternative hiding methods

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: Lain_13, arthur, erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

As mentioned in #756, RU AdList CSS Fixes uses CSS styles to hide elements without the site noticing:

Transform and opacity combined with position:fixed and negative left-top coordinates are primarily used as alternatives to display:none when site checks visibility of ad blocks. Transform:scale(0) is especially amazing at that.

Example:

@-moz-document domain("cloud.mail.ru")
{
  .b-layout__col_2_2 > style + div[id][class], 
    .content__left > style + div[id]:not(#breadcrumbs)
  {
    transform: scale(0) !important;
    opacity: 0 !important;
    position: fixed !important;
    top: -1000px !important;
  }
}

What to change

  • Add alternative methods for hiding elements in addition to display: none
    • position: fixed; left: -10000px; top: -10000px;
    • opacity: 0
    • transform: scale(0)
    • visibility: hidden
  • Provide filter authors with the ability to specify one or more hiding methods

Change History (6)

comment:1 Changed 18 months ago by mapx

  • Cc Lain_13 mapx added

comment:2 Changed 18 months ago by arthur

  • Cc arthur added

comment:3 Changed 10 months ago by erikvold

  • Cc erikvold added

comment:4 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

comment:5 Changed 31 hours ago by isabelladom

Last edited 31 hours ago by greiner (previous) (diff)

comment:6 Changed 31 hours ago by mapx

  • Cc mapx removed
Note: See TracTickets for help on using tickets.