#6562 closed change (fixed)

Remove provideFilterKeys parameter from getSelectorsForDomain and associated logic

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: mjethani, sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29757584/
https://codereview.adblockplus.org/29757588/
https://codereview.adblockplus.org/29757591/

Description (last modified by kzar)

Background

After a discussion in a codereview Manish and I realized the provideFilterKeys parameter for the getSelectorsForDomain function is no longer required. Additionally along with the changes for #6559 to replace Objects with Maps and Sets this means we can get rid of those keys all together.

What to change

  • Remove the provideFilterKeys parameter for the getSelectorsForDomain function.
  • Remove the unused getSelectors function.
  • Remove filter keys, since we can now use the filters themselves as they keys in lookups.

Change History (4)

comment:1 Changed 17 months ago by kzar

  • Description modified (diff)
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 6562 - Remove filter keys from the element hiding code

comment:4 Changed 16 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.