Opened on 04/06/2018 at 07:55:04 PM

Closed on 04/09/2018 at 09:48:53 PM

Last modified on 05/14/2018 at 09:02:36 AM

#6563 closed defect (fixed)

addonVersion in development builds doesn't contain build number anymore

Reported by: sebastian Assignee: tlucas
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, tlucas Blocked By:
Blocking: #6567 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by sebastian)


Adblock Plus development builds, any version since 352eabcb110d (~1.13.3)
All target platforms (i.e. Chrome, Firefox and Microsoft Edge)

How to reproduce

  1. Inspect the background page and observe the Network panel.
  2. Go to the options page.
  3. Force filter lists updates.


  1. Run ./ -t {chrome|gecko|edge} build.
  2. Unpack the generated adblockplus*-*.zip file.
  3. Run grep -R 'addonVersion =' from the directory with the unpacked build.

Observed behaviour

The addonVersion in the generated code (and therefore the addonVersion parameter in the filter list download requests) does not contain the build number (e.g. 3.0.2 instead of

Expected behaviour

For development builds, the addonVersion should always have four parts with the fourths part being the build/revision number.


This is a regression that can be pinned down to the buildtools dependency update performed in #5077. The related change in buildtools that caused this bug seems to be #5060 which mistakenly starts getting the version number directly from the metadata.

Attachments (0)

Change History (11)

comment:1 Changed on 04/06/2018 at 07:57:34 PM by sebastian

  • Description modified (diff)

comment:2 Changed on 04/06/2018 at 07:57:53 PM by sebastian

  • Summary changed from addonVersion in development builds doesn't contain build number anxmore to addonVersion in development builds doesn't contain build number anymore

comment:3 Changed on 04/09/2018 at 08:56:04 AM by tlucas

  • Owner set to tlucas

comment:4 Changed on 04/09/2018 at 09:59:18 AM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 04/09/2018 at 10:00:47 AM by tlucas

Please note, this will require a dependency update in adblockpluschrome to completely solve the issue.

comment:6 Changed on 04/09/2018 at 03:21:55 PM by tlucas

  • Blocking 6567 added

comment:7 Changed on 04/09/2018 at 03:22:56 PM by tlucas

For reference, i created #6567 to do the dependency update.

comment:8 Changed on 04/09/2018 at 09:48:25 PM by abpbot

A commit referencing this issue has landed:
Issue 6563 - Assure devbuild-number in info module

comment:9 Changed on 04/09/2018 at 09:48:53 PM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed on 04/19/2018 at 12:35:36 PM by sebastian

  • Description modified (diff)

comment:11 Changed on 05/14/2018 at 09:02:36 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. The addonVersion in requests from the extension now contain the build number again.

Firefox 59 / 55 / 51 / Windows 10
Chrome 66 / 58 / 49 / Windows 7
Opera 52 / 45 / 36 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
Note: See TracTickets for help on using tickets.