Opened 2 years ago

Last modified 2 years ago

#6563 closed defect

addonVersion in development builds doesn't contain build number anxmore — at Initial Version

Reported by: sebastian Assignee:
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29747571/

Description

Environment

Adblock Plus development builds, any version since 352eabcb110d (~1.13.5)
All target platforms (i.e. Chrome, Firefox and Microsoft Edge)

How to reproduce

  1. Inspect the background page and observe the Network panel.
  2. Go to the options page.
  3. Force filter lists updates.

or

  1. Run ./build.py -t {chrome|gecko|edge} build.
  2. Unpack the generated adblockplus*-*.zip file.
  3. Run grep -R 'addonVersion =' from the directory with the unpacked build.

Observed behaviour

The addonVersion in the generated code (and therefore the addonVersion parameter in the filter list download requests) does not contain the build number (e.g. 3.0.2 instead of 3.0.2.2007).

Expected behaviour

For development builds, the addonVersion should always have four parts with the fourths part being the build/revision number.

Notes

This is a regression that can be pinned down to the buildtoolsdepdency update performed in #5077. The related change in buildtools that caused this bug seems to be #5060 which mistakenly starts getting the version number directly from the metadata.

Change History (0)

Note: See TracTickets for help on using tickets.