Changes between Initial Version and Version 1 of Ticket #6565, comment 2


Ignore:
Timestamp:
04/10/2018 06:58:43 PM (18 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6565, comment 2

    initial v1  
    66>Also from just looking at the code, I cannot see how these changes will cause `checkWhitelisted()` to call `match()` which then calls `stringifyURL()` with `undefined` as `url` (if it didn't before). I might miss something, but without being able to reproduce the error, I cannot track it down. 
    77 
    8 From running this through the debugger it *seems* like it could be since previously the `onBeforeRequest` listener in lib/requestBlocker.js only called `checkWhitelisted` if `frame` was truthy, but now it doesn't. In any case I see that that `page.url` is undefined, but `details.url` isn't. Perhaps we should modify the line in `onBeforeRequest` where we create the `ext.Page` object to pass in the URL? 
     8From running this through the debugger it *seems* like it could be since previously the `onBeforeRequest` listener in lib/requestBlocker.js only called `checkWhitelisted` if `frame` was truthy, but now it always does. In any case I see that `page.url` is `undefined`, but `details.url` isn't. Perhaps we should modify the line in `onBeforeRequest` where we create the `ext.Page` object to pass in the URL?