Opened 11 months ago

Closed 11 months ago

Last modified 10 months ago

#6574 closed defect (fixed)

Sign in option being shown on tablets

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.4.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29749577

Description (last modified by diegocarloslima)

Environment

Galaxy Tab S2
Android 7.0
Adblock Browser 1.3.3

How to reproduce

  1. Install the app and open it
  2. Go to the dropdown menu and select Settings

Observed behaviour

There's a Sign in option in the General settings (See attached screenshot).

Expected behaviour

The Sign in option should be hidden.

Attachments (1)

Samsung Galaxy Tab S2 — Live Testing _ Sauce Labs 2018-04-09 19-00-24.png (168.1 KB) - added by diegocarloslima 11 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 11 months ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 11 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 6574 - Sign in option being shown on tablets

comment:4 Changed 11 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 10 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.