Opened 5 years ago

Closed 5 years ago

#658 closed defect (incomplete)

sidebar.js usage of HTTP cache v2 APIs is out-dated

Reported by: honzab Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform:
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description

sidebar.js usage of HTTP cache v2 APIs is out-dated

During inspection of your code for usage of the old cache APIs (now completely disabled) I have found a following issue:

at /chrome/content/ui/sidebar.js:373:

there is no longer nsICacheEntryOpenCallback.ENTRY_VALID - actually never was, that code never went behind the project "Gum" tree.

Fix: migrate to nsICacheEntryOpenCallback.ENTRY_WANTED

Change History (6)

comment:1 Changed 5 years ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox

I am confused by this report, which extension are you looking at? Adblock Plus doesn't have the code in question - I only filed #660 now in response to your blog post, we aren't using HTTP cache v2 API yet. Yet the details do sound like Adblock Plus. Is there an Adblock Plus fork I am not aware of?

comment:2 Changed 5 years ago by trev

  • Cc trev added

comment:3 Changed 5 years ago by philll

Falsely spam-blocked comment by honzab:
Ups, I think I found the problem in a different extension. I was confused, I mistakenly thought it was Adblock Plus. But the extension in question was Autoproxy2. No idea how to reach to the author.

Definitely not an Adblock bug.

Please close this as INVALID.

Thanks. Sorry for spam!

comment:4 Changed 5 years ago by honzab

BTW, can you please cc me or even let me add comments/react to bug 660?

Thanks.

comment:5 Changed 5 years ago by philll

@honzab I added you to cc of #660. You should be able to comment any issue anyway. In the last case, our recently introduced spam filter has just falsely blocked your post.

comment:6 Changed 5 years ago by mapx

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.