#6583 closed change (fixed)

Make sure files have correct license headers

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/14

Description

Background

Adblockpluschromium has files written by us and third-party files mixed. We want to make sure we keep track of what is licensed under which license.

What to change

Make sure all files we add to adblockpluschromium have correct license headers. Right now chrome/browser/android/adblock/adblock_bridge.cc, chrome/browser/android/adblock/adblock_bridge.h and chrome/android/java/src/org/chromium/chrome/browser/adblock/AdblockBridge.java seem to have wrong license headers.

Change History (7)

comment:1 Changed 20 months ago by asmirnov

@ollie should originalChromium team created cpp/java files and then modified by Eyeo have Eyeo license?

comment:2 Changed 20 months ago by asmirnov

@ollie: what types of files (extensions) should have Eyeo license header?

comment:3 Changed 20 months ago by asmirnov

here is full files list touched by me (to think about my questions above):

antoine@antoine-vm:~/chromium/src$ git log --no-merges --author="Anton Smirnov" --name-only --pretty=format:"" | sort -u

base/android/linker/config.gni
build/android/gyp/aar.py
build/config/android/config.gni
build/config/android/internal_rules.gni
build/config/android/rules.gni
chrome/android/BUILD.gn
chrome/android/java/AndroidManifest.xml
chrome/android/java/res/xml/main_preferences.xml
chrome/android/java_sources.gni
chrome/android/java/src/org/chromium/chrome/browser/adblock/AdblockBridge.java
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
chrome/android/java/strings/android_chrome_strings.grd
chrome/browser/android/adblock/adblock_bridge.cc
chrome/browser/android/adblock/adblock_bridge.h
chrome/browser/android/preferences/pref_service_bridge.cc
chrome/browser/BUILD.gn
chrome/browser/io_thread.cc
chrome/browser/net/chrome_network_delegate.cc
chrome/browser/net/chrome_network_delegate.h
chrome/browser/net/chrome_network_delegate_unittest.cc
chrome/browser/profiles/profile_io_data.cc
chrome/browser/profiles/profile_io_data.h
chrome/browser/ui/browser_ui_prefs.cc
chrome/common/chrome_isolated_world_ids.h
chrome/common/pref_names.cc
chrome/common/pref_names.h
content/browser/web_contents/web_contents_impl.cc
content/public/browser/notification_types.h
DEPS
.gn
third_party/.gitignore
third_party/libadblockplus_android/BUILD.gn
third_party/libadblockplus_android/clear.py
third_party/libadblockplus_android/delete_dir.py
third_party/libadblockplus_android/prepare_build_tools.py
third_party/libadblockplus_android/proguard-adblock.txt
third_party/libadblockplus_android/subproc.py
third_party/libadblockplus/BUILD.gn
third_party/libadblockplus_common/abi.gni
third_party/libadblockplus_common/delete_dir.py
third_party/libadblockplus_common/subproc.py
third_party/libadblockplus/delete_dir.py
third_party/libadblockplus/download_ndk.py
third_party/libadblockplus/prepare_dependencies.py
third_party/libadblockplus/subproc.py

comment:4 Changed 20 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:5 Changed 20 months ago by oleksandr

  • I don't think we can put a license on a file that was not 100% created by us. So our headers should be only on files created by you.
  • Just having license in .cpp, .cc, .h, .java and .py files should be enough. Build tools files typically have no license headers anyway.
  • We still need to confirm with legal on how to legally distribute our Chromium fork to partners.

comment:6 Changed 20 months ago by asmirnov

  • Summary changed from Make sure files in adblockpluschromium have correct license headers to Make sure files have correct license headers

comment:7 Changed 20 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.