Changes between Initial Version and Version 1 of Ticket #6592, comment 11


Ignore:
Timestamp:
04/18/2018 04:50:47 PM (19 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6592, comment 11

    initial v1  
    11Ok, thanks. With the `urls: ["*://content.uplynk.com/ext/*"]` restriction in the test extension and the `||content.uplynk.com/preplay/*` filter in Adblock Plus, the pre-roll indeed gets blocked while the video still plays. This demonstrates a case for a new filter options like this. 
    2  
    3 Now, let's bikeshed about the name and semantics. I personally find `$rewrite` slightly ambiguous (since it could be mistaken as a filter option, or potentially conflict with a future filter option, that rewrties the response), also I haven't seen any regular expression implementation that talks about rewriting when replacing a group. `$replace` seems a somewhat better name IMO. Also what is about multiple matching groups? And can you actually combine `||` with regular expression syntax in filters?