Opened on 04/18/2018 at 07:19:25 PM

Closed on 06/14/2018 at 09:50:00 AM

#6596 closed change (fixed)

Update v8 to ~ in libadblockplus

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere, asmirnov Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Supposedly the next version which will be required is or one which is based on it, see In order to not block other teams it should be done in time.

Please pay attention that even 6.6.346.24, which is used for today in the stable version of chromium, has no gyp files anymore, therefore it requires to use depot_tools and GN/ninja. It complicates a lot of things, so IMO the support of V8 source in libadblockplus should be reconsidered, e.g instead one could either fetch binaries directly or prepare them and specify via the command line, or we can even switch to depot_tools instead of ensure_dependencies and still use V8 sources but with subtle differences.

Perhaps #5503 is blocking.

Attachments (0)

Change History (5)

comment:1 Changed on 04/19/2018 at 08:02:50 AM by sergz

  • Owner set to sergz

comment:2 Changed on 05/16/2018 at 10:29:36 AM by sergz

  • Review URL(s) modified (diff)

comment:3 Changed on 05/16/2018 at 10:38:40 AM by sergz

  • Status changed from new to reviewing

comment:4 Changed on 06/14/2018 at 09:45:10 AM by abpbot

A commit referencing this issue has landed:
Issue 6596 - update to work with v8

comment:5 Changed on 06/14/2018 at 09:50:00 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.