Opened 8 months ago

Closed 7 months ago

#6605 closed change (fixed)

Add support for bookmark specific expected outputs to CMS tests.

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: Sitescripts Keywords: CMS
Cc: sebastian, kvas, rhowell Blocked By:
Blocking: #5618, #6545 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29753617/

Description (last modified by kvas)

Background

While testing #6545 I ran into a problem with the tests where sitemap.tmpl renders differently based on the bookmark the site is generated from (this functionality was added with #4992). Adding bookmark specific expected outputs will also be handy with #5618 as well, since static content links are generated with a special character ? and the revision number that link is from.

What to change

Change the test suite's expected output parsing to support the addition of a delimiting character for bookmark specific outputs following the test_type character.

Note

I have implemented this already in this review but realized it would be much better to have a separate ticket, so that I can add some documentation around this as well without muddying up the patch.

Change History (4)

comment:1 Changed 8 months ago by jsonesen

  • Description modified (diff)

comment:2 Changed 8 months ago by kvas

  • Blocking 5618, 6545 added
  • Component changed from Unknown to Sitescripts
  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Review URL(s) modified (diff)

I fixed the issue links and added blocked tickets and the review link. Also set it to ready.

comment:3 Changed 8 months ago by jsonesen

Wouldn't this ticket actually be blocked by 6545? Since it needs to land with the test suite changes first, then the doc added?

comment:4 Changed 7 months ago by jsonesen

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.