Opened 14 months ago

Closed 14 months ago

Last modified 12 months ago

#6610 closed change (fixed)

Use inline style for -abp-properties if there's no tabs.removeCSS support

Reported by: mjethani Assignee: mjethani
Priority: Unknown Milestone:
Module: Core Keywords: circumvention
Cc: hfiguiere, kzar, sergz, amrmak, arthur Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29759621/

Description (last modified by mjethani)

Background

With revision ae47c9d78ac7 in adblockpluschrome we stopped creating a shadow root on Chrome 66+ and Firefox. On Chrome 66 in particular, this makes -abp-properties easier to circumvent, because we are not using user style sheets for this type of filter for lack of tabs.removeCSS (#6422). In order to mitigate this, we should switch to using inline style="display: none !important" for -abp-properties as well.

What to change

In lib/content/elemHideEmulation.js always prefer inline styles for all types of selectors unless useInlineStyles is set to false.

Change History (9)

comment:1 Changed 14 months ago by mjethani

  • Cc hfiguiere kzar sergz added

comment:2 Changed 14 months ago by amrmak

  • Cc amrmak added

comment:3 Changed 14 months ago by arthur

  • Cc arthur added

comment:4 Changed 14 months ago by mjethani

  • Description modified (diff)

comment:5 Changed 14 months ago by mjethani

  • Review URL(s) modified (diff)

comment:6 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 6610 - Prefer inline style for :-abp-properties()

comment:7 Changed 14 months ago by mjethani

  • Resolution set to fixed
  • Status changed from new to closed

Sorry, I landed the change for this, but this is not set to ready. Can I close this?

comment:8 Changed 14 months ago by mjethani

  • Owner set to mjethani

comment:9 Changed 12 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Filters using abp-properties use inline styles in browsers where tab.removeCSS is not supported.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

Note: See TracTickets for help on using tickets.