Opened 5 years ago

Closed 5 years ago

#662 closed change (fixed)

[eyeo.com] Job links shouldn't use anchors

Reported by: fhd Assignee: saroyanm
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: kirill@…, sebastian, greiner, saroyanm Blocked By: #2178, #2179, #2181
Blocking: #2131 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5994668214976512/

Description (last modified by saroyanm)

Background

We currently use job links of this form:
https://eyeo.com/jobs#web-developer

This makes it impossible for us to see how many page views individual job ads got - it all ends up as https://eyeo.com/jobs in the logs.

What to change

  1. create generic header (Ex: includes/jobs/generic-header.tmpl) and generic footer (Ex: includes/jobs/generic-footer.tmlp) for job openings page, the information about job openings should go between this generic templates.
  2. create pages/jobs.tmpl Where content of the overview page should be placed.
  3. create pages/jobs/JOBTITLEs.md for each job opening, where the content of the job should be placed.
  4. create pages/jobs/not-available with text like The position you are looking for is no longer available this page will be used to redirect users in case they open the non existing job page.

Change History (23)

comment:1 Changed 5 years ago by trev

  • Component changed from Infrastructure to Websites

comment:2 Changed 5 years ago by Kirill

  • Cc kirill@… added
  • Platform set to Unknown

comment:3 Changed 5 years ago by saroyanm

What about using query strings ?
Something like:
https://eyeo.com/jobs?position=web-developer

@kirill will that work for you ?

comment:4 Changed 5 years ago by saroyanm

  • Ready unset

comment:5 Changed 5 years ago by saroyanm

  • Cc sebastian greiner added

@Sebastian would it be possible to use query string parameters value in the jinja template ?
I'm looking for similar solution:

<? include jobs/openings/{{ request.args.get("position") }} ?>

I think if we can use url parameter value, than we can have solution for current ticket, otherwise I see only current solutions:

  1. Use Javascript to parse url and show appropriate content (Which will have accessibility issues)
  2. Create separate page for each position (this will provide problems in maintaining)

I'm actually new to our CMS, so maybe there is some other option I've missed.

Last edited 5 years ago by saroyanm (previous) (diff)

comment:6 Changed 5 years ago by sebastian

No you can't. It's a static page generator, no dynamic web page framework. Neither would URLs with the job title given in the query string be nice. I actually realized that problem myself in the past. And started to make each job posting an own pages (this is how you would do it), but it became rather complex, that I dumped the code again.

comment:7 Changed 5 years ago by saroyanm

  • Cc saroyanm added

Sorry, this got lost from my radar.
Yes that's a problem, so we will need to create separate page for each job opening in that case, it will make the process less manageable so Maren will need to ask us to create new job opening each time.
But I don't see other solution, also in case we will implement metadata would be nice to have separate metadatas for each job opening and beside that I think we will need to change the other pages for consistency and ability to share.

I'll open discourse discussion for that.

comment:8 Changed 5 years ago by saroyanm

  • Description modified (diff)
  • Ready set

@Sebastian thanks for hints, the description updated.

comment:9 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:10 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:11 Changed 5 years ago by saroyanm

  • Blocking 2131 added

comment:12 Changed 5 years ago by saroyanm

  • Owner set to saroyanm

comment:13 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:14 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:15 Changed 5 years ago by saroyanm

  • Description modified (diff)

comment:16 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 Changed 5 years ago by saroyanm

  • Description modified (diff)

Updated the not-available page text after aligning with Maren.

comment:18 Changed 5 years ago by trev

  • Blocked By 2178 added

comment:19 Changed 5 years ago by trev

  • Blocked By 2179 added

comment:20 Changed 5 years ago by trev

  • Blocked By 2180 added

comment:21 Changed 5 years ago by trev

  • Blocked By 2181 added

comment:22 Changed 5 years ago by trev

  • Blocked By 2180 removed

comment:23 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.