Changes between Version 26 and Version 31 of Ticket #6622


Ignore:
Timestamp:
05/22/2018 11:51:24 AM (17 months ago)
Author:
hfiguiere
Comment:

Ah right. Removing.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6622

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
    • Property Milestone changed from to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Ticket #6622 – Description

    v26 v31  
    3030  - Issue #6652 - Do not push to unconditional selectors array 
    3131  - Issue #6592 - Implement $rewrite filter option 
    32 - Update the `adblockplusui` dependency for the changes in #6670. 
    3332- Implement the rewrite in `requestBlocker.js` by calling the function for core that will perform it. This is handled as an exception of blocking in the same handler. 
    3433 
    3534=== Hint for testers === 
    3635* Test that regular request blocking still works. 
    37 * Test filters with rewrite option. 
     36* Test filters with rewrite option. The developer tool panel relies on changes for issue #6670 that may not have landed at the time of writing. 
    3837  * Basic rewrite: add filter `/(testpages\.adblockplus\.org\/css\/testpages\.css)\?14$/$rewrite=$1?42` and visit https://testpages.adblockplus.org/en/testcases/css/03 . You should notice the rewrite in the Adblock Plus developer tool panel. 
    3938  * Rewrite to relative URL. Should succeed. Add filter `/testpages\.adblockplus\.org(\/css\/testpages\.css)\?14$/$rewrite=$1?42` (and make sure the previous filter is removed). You should notice the rewrite in the Adblock Plus developer tool panel.