Opened 17 months ago

Last modified 15 months ago

#6622 closed change

Implement rewrite filter option — at Version 7

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords: circumvention
Cc: sebastian, kzar, Ross, mapx, arthur Blocked By: #6592
Blocking: #6242 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29760707/

Description (last modified by hfiguiere)

Background

Issue #6592 introduce a new rewrite option to rewrite URL instead of blocking. This is to implement the WebExt side of the rewrite

What to change

  • Update dependencies to have the patch for issue #6592 from core.
  • Implement the rewrite in requestBlocker.js by calling the function for core that will perform it. This is handled as an exception of blocking in the same handler.
  • Update UI to display the "rewritten to" information in the devtools.
  • This will require a dependency update on adblockplusui.

Hint for tester

  • Test that blocking filters without rewrite aren't broken
  • Test filters with rewrite option.
    • Rewrite to relative URL. Should succeed.
    • Rewrite to different origin: Should fail the original request let through
  • Ensure that the rewrites are logged accordingly into the developer tools.

Change History (7)

comment:1 Changed 17 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 17 months ago by hfiguiere

  • Keywords circumvention added

comment:3 Changed 17 months ago by hfiguiere

  • Blocking 6242 added

comment:4 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:5 Changed 17 months ago by hfiguiere

  • Description modified (diff)
  • Review URL(s) modified (diff)

comment:6 Changed 17 months ago by greiner

For reference: I've created gitlab#76 to come up with a simple design based on the one provided via the review.

While that's being worked on, we can continue the review with the existing code.

comment:7 Changed 17 months ago by hfiguiere

  • Description modified (diff)
Note: See TracTickets for help on using tickets.