Opened 5 years ago

Closed 5 years ago

#664 closed change (fixed)

[intraforum] Remove or increase the mention limit

Reported by: fhd Assignee: matze
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5649449867018240

Description

Background

Right now, Discourse won't allow posts that mention more than 10 people, probably to avoid spam. Since spam isn't really an issue on the intraforum and since mentioning tons of people makes sense in some cases, we should get rid of that limit.

What to change

Ideally, there shouldn't be any limit to how many people you can mention. If that's not possible, we should set it to the highest number we can.

Change History (6)

comment:1 Changed 5 years ago by matze

  • Owner set to matze
  • Platform set to Unknown

comment:2 Changed 5 years ago by matze

There is an distinct option available for both, authenticated and new users:

vagrant@server10:~$ grep --only-matching -R '\<SiteSetting\..*mention.*\>' /opt/discourse/lib
/opt/discourse/lib/validators/post_validator.rb:SiteSetting.max_mentions_per_post
/opt/discourse/lib/validators/post_validator.rb:SiteSetting.newuser_max_mentions_per_post

I'll apply a discourse::sitesetting directive via puppet, but one can also adjust this easily using the /admin panel.

comment:3 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by matze

By the way: One cannot remove the limit without patching the code. So I've increased it - but only to 50 rather than INT_MAX because I do not consider the latter option that wisely, and future adjustments - if necessary - are a matter of minutes only. However, feel free to request any other number explicitly.

comment:5 Changed 5 years ago by fhd

I've changed this in the admin interface a little while ago, currently we can mention up to 100 people.

comment:6 Changed 5 years ago by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.