Opened 2 years ago

Closed 2 years ago

Last modified 14 months ago

#6641 closed defect (fixed)

Copyright year in about dialog is out of date

Reported by: Ross Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, kzar, greiner, juliandoucette, Kai, jeen Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/108

Description (last modified by greiner)

Environment

ABP 3.0.4.2034
Chrome 66 / Windows 10

How to reproduce

  1. Select the [About Adblock Plus] link.

Observed behaviour

The dialog displays Copyright © 2017 eyeo GmbH

Expected behaviour

The dialog to display the current year.

What to change

Replace year in copyright notice on first-run page with "2006-present".

Change History (9)

comment:1 Changed 2 years ago by sebastian

  • Cc greiner added

For reference this is what we use as copyright notice in the source files and some other places: Copyright (C) 2006-present eyeo GmbH. That way it doesn't need to be updated in the future.

comment:2 Changed 2 years ago by greiner

  • Cc juliandoucette Kai added
  • Description modified (diff)

I agree, I've also suggested to use the phrasing you suggested for the first-run page (see gitlab#173). Otherwise we could evaluate the year at runtime. Besides that, I'm pretty sure that we don't even need a copyright notice anywhere so we could even think about getting rid of it or at least removing the year from it.

Note that the same issue also exists in the footer of adblockplus.org which the new first-run page is based on so it'd be great if we could have the same fix for UI and Websites.

comment:3 Changed 2 years ago by greiner

  • Cc jeen added

Note that the way it's defined in the spec is

Copyright © {current year} All rights reserved. Adblock Plus® is a registered trademark of [eyeo GmbH](https://eyeo.com).

so the year appears to be expected to be inserted automatically.

comment:4 Changed 2 years ago by greiner

  • Owner set to greiner
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 2 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by greiner

  • Blocking 6936 added

comment:7 Changed 2 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6641 - Fixed: Year in copyright notice was hardcoded

comment:9 Changed 14 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.