Opened 6 months ago

Closed 5 months ago

Last modified 4 months ago

#6645 closed change (fixed)

Collapse elements through user style sheets if possible

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29770568

Description (last modified by sebastian)

Background

With #5899 we started to collapse <video> and <audio> elements (that don't have <source> or <track> child elements) using a (user) style sheet. However, there are other elements (e.g. images and iframes) that could be hidden based on their src attribute though a style sheet as well.

What to change

Hide elements that have been blocked, by adding a selector matching their src and/or srcset attribute to a style sheet (instead of overriding their style attribute) where applicable.

Change History (5)

comment:1 Changed 6 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 months ago by abpbot

comment:3 Changed 5 months ago by sebastian

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 months ago by abpbot

comment:5 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This seems to be working as expected.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

Note: See TracTickets for help on using tickets.