Opened 22 months ago

Closed 22 months ago

Last modified 20 months ago

#6645 closed change (fixed)

Collapse elements through user style sheets if possible — at Version 3

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29770568

Description (last modified by sebastian)

Background

With #5899 we started to collapse <video> and <audio> elements (that don't have <source> or <track> child elements) using a (user) style sheet. However, there are other elements (e.g. images and iframes) that could be hidden based on their src attribute though a style sheet as well.

What to change

Hide elements that have been blocked, by adding a selector matching their src and/or srcset attribute to a style sheet (instead of overriding their style attribute) where applicable.

Change History (3)

comment:1 Changed 22 months ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 22 months ago by abpbot

comment:3 Changed 22 months ago by sebastian

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.