Changes between Initial Version and Version 1 of Ticket #6647, comment 19


Ignore:
Timestamp:
05/07/2018 12:10:12 PM (13 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6647, comment 19

    initial v1  
    1 We cannot convert filters reliably, for example the umlaut in filters like `ä` or `||foo*bär` could either match in the domain or path of the URL. For a script to perform a one time conversion (as Manish suggested) we can make unsafe assumptions for those cases, and trust filter lists author to review the output, but this isn't an option for an unsupervised conversion done inside Adblock Plus. 
     1We cannot convert filters reliably, for example the umlaut in filters like `ä` or `||foo*bär` could either match in the domain or path of the URL. For a script to perform a one time conversion (as Manish suggested) we can make unsafe assumptions for those cases, and trust filter list authors to review the output, but this isn't an option for an unsupervised conversion done inside Adblock Plus. 
    22 
    33Also this would only address the performance penalty (and only partially since we'd trade in performance during filter matching for overhead during filter parsing). However, the argument that started this whole discussion is that spelling out domains in unicode is error-prone (see the issue description).