Opened 2 years ago

Closed 2 years ago

#6650 closed defect (duplicate)

Update buildtools dependency to 168dac24ad9e

Reported by: tlucas Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar, geo, oleksandr Blocked By:
Blocking: #6621 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



In #6635, we introduced the exposure of webpack's resolve.alias-machinery. In order to solve #6621, we need this in adblockpluschrome.

Included changes in buildtools

The list of changes imported by this is:

a8b5bbe92c0a Noissue - Adapt best practices for trailing commas Sebastian Noack

What to change

Update the buildtools dependency to:

mercurial git
168dac24ad9e f679caf

According to #6625, include resolve.alias and it's documentation in the repositories

Hints for testers

The builds should not have changed at all.

Change History (5)

comment:1 Changed 2 years ago by tlucas

  • Cc sebastian kzar geo oleksandr added

comment:2 Changed 2 years ago by sebastian

As long as these are the only new changes in buildtools, I'm fine with performing the dependency update implicitly as part of #6621. Before #6621 lands, this dependency update won't have any effect on the builds anyway, and that way we can also validate that the changed done for #6625 are sufficient.

FWIW, geo failed so far to use the module switching mechanism introduced in #6625. Perhaps you can show her a working example similar to what we want to do in #6621.

comment:3 Changed 2 years ago by tlucas

Geo and i got it running yesterday, so from my point of view we're all good.

I wouldn't mind the implicit update with #6621 either - what do you think, Geo?

In case we all agree here, i'll close this ticket. (@Geo, feel free to contact me again if you need any support)

comment:4 Changed 2 years ago by geo

I think the implicit update with #6621 is fine as long as it doesn't block any other issues.

comment:5 Changed 2 years ago by tlucas

  • Resolution set to duplicate
  • Status changed from new to closed

The update will be done in #6621.

Note: See TracTickets for help on using tickets.