Opened 19 months ago

Closed 3 months ago

#6664 closed change (rejected)

Update the buildtools dependency for adblockpluscore

Reported by: tschuster Assignee: tschuster
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: mjethani, kzar, erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29802595/

Description (last modified by kzar)

Background

Currently adblockpluscore uses a very old buildtools version from 2016 (https://hg.adblockplus.org/buildtools/rev/3816c08c0f98). This even still includes jshdyra, which we don't need anymore with WebExtensions everywherea and the generate_docs.py script seems to be broken. I propose updating the version to what we are already using in adblockpluschrome.

What to change

Update the buildtools dependency to FIXME.

Change History (8)

comment:1 Changed 19 months ago by kzar

  • Milestone Adblock-Plus-for-Chrome-Opera-Firefox-next deleted

comment:2 Changed 19 months ago by kzar

  • Cc mjethani kzar added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Summary changed from Update adblockpluscore buildtools dependency to Update the buildtools dependency for adblockpluscore

comment:3 Changed 18 months ago by mjethani

  • Priority changed from P2 to P3
  • Ready set

comment:4 Changed 18 months ago by tschuster

  • Review URL(s) modified (diff)

comment:5 Changed 18 months ago by kzar

  • Ready unset

Please could you update the issue to include the revision you're updating the dependency to? Also please could you go through the changes included to check if any are relevant and list those and check if they have any integration notes?

comment:6 Changed 18 months ago by tschuster

The current version is from 2016. I looked through the changesets and I think most of these aren't really relevant for the buildtools, it's mostly about dropping support for Firefox, Safari and thinks like that. I would however

I do have to correct myself, adblockpluschrome also seems to use some old version. I am not sure why I thought adblockpluschrome used that specific version.

comment:7 Changed 13 months ago by erikvold

  • Cc erikvold added

comment:8 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.