Opened 2 years ago

Closed 2 years ago

#6669 closed change (fixed)

Replace critera argument to ElemHide.getSelectorsForDomain with specificOnly

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Core Keywords:
Cc: sergz, mjethani Blocked By:
Blocking: #6652 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Since ElemHide.NO_UNCONDITIONAL was added for the legacy Firefox extension we can remove it and the other related constants. Instead replacing the criteria argument of getSelectorsForDomain with a specificOnly bool.

What to change

Replace the critera argument of getSelectorsForDomain with a specificOnly boolean argument which defaults to false. Remove the unused constants.

Integration notes

Modify any ElemHide.getSelectorsForDomain calls to pass a specificOnly boolean instead of one of the constants.

Change History (3)

comment:1 Changed 2 years ago by mjethani

I was just going to suggest this.

We should still maintain the distinction between "unconditional" and "conditional" internally though, because we can use the cache of the former category of selectors in all cases while the latter applies in most cases but not all.

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6669 - Remove unused ElemHide.NO_UNCONDITIONAL constant

comment:3 Changed 2 years ago by kzar

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.