Opened 17 months ago

Closed 17 months ago

Last modified 16 months ago

#6670 closed change (fixed)

Log URL rewrites in DevTools

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: kzar, sebastian, greiner, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29770586/

Description (last modified by hfiguiere)

Background

In issue #6592, we introduce an option to rewrite URL. We want to have this logged in the DevTools as part of the WebExtension change covered by issue #6622

What to change

  • Modify the UI template for filter log
  • Add code to populate that template
  • Add mockup data

Note

From https://issues.adblockplus.org/ticket/6622#comment:6

Design request in gitlab#76

Change History (10)

comment:1 Changed 17 months ago by hfiguiere

  • Status changed from new to reviewing

comment:2 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:3 Changed 17 months ago by hfiguiere

  • Cc kzar sebastian mjethani greiner added

comment:4 Changed 17 months ago by hfiguiere

  • Cc Ross added; mjethani removed

comment:5 Changed 17 months ago by hfiguiere

Last edited 17 months ago by hfiguiere (previous) (diff)

comment:6 Changed 17 months ago by greiner

As requested, I've moved the commit to the release branch that's meant to be included in the next extension release (see https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/edb830885ffcb3034ba8c9b5d7ab0b7c408b50c8) because I've originally pushed it to the latest release branch.

comment:7 Changed 17 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 17 months ago by hfiguiere

  • Blocking 6622 removed

comment:9 Changed 17 months ago by abpbot

comment:10 Changed 16 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This appears to be working as expected. Rewrites correctly appear in the devtools panel log.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

Note: See TracTickets for help on using tickets.