Changes between Initial Version and Version 1 of Ticket #6675


Ignore:
Timestamp:
05/17/2018 10:24:06 AM (15 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6675

    • Property Cc tlucas kzar sebastian added
    • Property Component changed from Core to Automation
    • Property Summary changed from BuildTools for AdBlock to info module placeholder file included in AdBlock bundle by WebPack
    • Property Keywords adblock webpack added; buildtools removed
    • Property Owner set to kzar
  • Ticket #6675 – Description

    initial v1  
    22Windows 10 version 1803 
    33Chrome 66.0.3359.139 (Official Build) (64-bit) 
    4 Upgrading AdBlock to ABP Core 3.1 
    5  
     4AdBlock devenv build from the [https://github.com/betafish-inc/adblock-next-gen/tree/update-ABP-Core adblock-next-gen/tree/update-ABP-Core] branch. 
    65 
    76=== How to reproduce === 
    8 The code in the PR is a work in progress to update AdBlock to ABP Core 3.1. 
    9  
    10 https://github.com/betafish-inc/adblock-next-gen/pull/308 
    11  
     71. Open the background console for the extension. 
    128Complete a local dev build, and side load the extension. 
    139 
    14 You should see the following JavaScript exception: 
     10=== Observed behaviour === 
     11The following JavaScript exception: 
    1512 
     13{{{ 
    1614 Uncaught (in promise) Error: Attempt to change preference type 
    1715     at Object.set (prefs.js:229) 
    1816     at Object.set [as currentVersion] (prefs.js:328) 
    1917     at detectFirstRun (subscriptionInit.js:57) 
    20  
    21 === Observed behaviour === 
    22  
     18}}} 
    2319 
    2420=== Expected behaviour === 
    25 No exceptions should be thrown, and the AdBlock /installed should open. 
     21No exceptions. 
     22 
     23=== Notes === 
     24- It appears that WebPack sometimes replaces the info module requires with `__webpack_require__(5)` instead of `__webpack_require__(11)` in the lib/adblockplus.js bundle, which in turn includes the dummy buildtools/info.js file instead of the contents as provided by info-loader.js.