Opened on 05/17/2018 at 04:41:44 PM

Closed on 07/24/2018 at 11:49:58 AM

Last modified on 08/21/2018 at 12:38:08 PM

#6680 closed defect (fixed)

Element hiding emulation doesn't work with :-abp-properties() and dynamic DOM updates

Reported by: amrmak Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords: circumvention
Cc: mjethani, scuturic, arthur, hfiguiere, kzar Blocked By:
Blocking: #6437 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)


ABP 3.1 on Chrome 66 OR ABP 3.1 on Firefox

Subscriptions: EasyList Germany+EasyList

How to reproduce

  1. Browse to
  2. Add the filters: (ad on top is alternating, hence the two filters) 10px;) > img 5px;) > img
  1. Refresh the page.

Observed behaviour

AdDefend ad on top is not hidden

Expected behaviour

AdDefend ad on top is hidden


Followed Manish's suggestion to try it on an older release, and it works as expected (tested with ABP 3.0.4 on Firefox 60.0.1).

Notes for testers

  • Testing in Firefox should be fine
  • Testing in Chrome, mentionned in comment 7 might be more tricky as it seems that even without AdblockPlus the ads don't display.

Here's a test:

setTimeout(() =>
  let styleElement = document.createElement("style");
  styleElement.sheet.insertRule("#toHide {background-color: #000}");
  setTimeout(() =>
    let divElement = document.createElement("div"); = "toHide";
    divElement.textContent = "I should be gone!"; = "white";

With the filter #?#:-abp-properties(background-color: rgb(0, 0, 0)) the div element "I should be gone!" should be hidden after a second or two.

Attachments (0)

Change History (17)

comment:1 Changed on 05/17/2018 at 07:49:42 PM by hfiguiere

  • Cc hfiguiere added

comment:2 Changed on 05/18/2018 at 03:18:24 PM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 05/18/2018 at 03:18:48 PM by hfiguiere

  • Keywords circumvention added

comment:4 Changed on 06/11/2018 at 12:18:43 PM by mjethani

  • Component changed from Unknown to Core
  • Priority changed from Unknown to P2

comment:5 Changed on 07/19/2018 at 01:48:51 AM by hfiguiere

The regression is caused by

However the case is as follow: the website insert styles manually. This is a test case not covered in our test suite (I have one now)

Last edited on 07/19/2018 at 02:59:49 AM by hfiguiere

comment:6 Changed on 07/23/2018 at 01:04:07 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 07/23/2018 at 01:35:18 PM by hfiguiere

As of today, on Chrome 67.0.3396.99 (macOS), the ad no longer shows, even without Adblock Plus and in a private browser. Possibly a site specific issue.

On the other hand, it reproduces in Firefox as originally reported.

comment:8 Changed on 07/24/2018 at 10:18:44 AM by kzar

I guess this is not a release blocker, since it is not a regression since the last release, so I agree on P2. It would be cool to include a fix however.

comment:9 Changed on 07/24/2018 at 11:48:51 AM by abpbot

A commit referencing this issue has landed:
Issue 6680 - PropsSelector also depend on DOM modifications

comment:10 Changed on 07/24/2018 at 11:49:58 AM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 07/24/2018 at 01:15:46 PM by hfiguiere

  • Description modified (diff)

comment:12 Changed on 07/24/2018 at 07:33:01 PM by mjethani

  • Summary changed from Element hiding emulation doesn't work as expected to Element hiding emulation doesn't work with :-abp-properties() and dynamic DOM updates

comment:13 Changed on 07/24/2018 at 07:33:27 PM by mjethani

  • Cc kzar added
  • Ready set

comment:14 Changed on 07/24/2018 at 07:35:39 PM by mjethani

  • Blocking 6437 added

comment:15 Changed on 08/21/2018 at 11:25:45 AM by Ross

I've tried looking at this but am not sure if I'm actually seeing any AdDefend ads at this point. I also tried creating a small test page that adds a div with an img and the margin but I couldn't get a filter to match that either.

Is it possible to get a test case in the same vain as #6803 or confirmation AdDefend ads are still running on the site above?


comment:16 Changed on 08/21/2018 at 12:37:30 PM by mjethani

  • Description modified (diff)

comment:17 Changed on 08/21/2018 at 12:38:08 PM by mjethani

Ross, I've added a test for this in the issue description.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.