Opened 17 months ago

Last modified 7 months ago

#6683 new defect

Orca crashes when logging in to Discourse

Reported by: jwangenheim Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Anton Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Google Pixel C
Latest build of Orca (0.1.2)
Adblocking enabled. With adblocking disabled, the app does not crash.

How to reproduce

  1. visit http://intraforum.adblockplus.org/
  2. tap login (takes you through GoogleApps login)
  3. type in your email and password, and hit login
  4. the callback automatically takes you back to Discourse

Observed behaviour

Orca crashes

Expected behaviour

Orca should not crash but redirect to Discourse

Attachments (4)

SauceLabs_Log_Google_Pixel_real_18-05-2018_10-33-55.txt (107.7 KB) - added by jwangenheim 17 months ago.
intraforum_no_crash.txt.zip (11.6 KB) - added by asmirnov 17 months ago.
no crash log for me
device-2018-05-18-153757.png (239.9 KB) - added by asmirnov 17 months ago.
no crash screenshot for me
bugreport-bullhead-OPM4.171019.016.A1-2018-05-23-13-57-16.zip (3.9 MB) - added by asmirnov 17 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 17 months ago by asmirnov

attached log part:

2018-05-18 20:31:57.830 WARN:   chromium : [WARNING:adblock_bridge.cc(258)] Adblock: received onLoad() notification of type 4 with url https://intraforum.adblockplus.org/
201	2018-05-18 20:31:57.836 WARN:   chromium : [WARNING:adblock_bridge.cc(97)] Adblock: got 19207 selectors for domain intraforum.adblockplus.org
202	2018-05-18 20:31:57.858 WARN:   chromium : [WARNING:adblock_bridge.cc(173)] Adblock: element hiding - generated JS
203	2018-05-18 20:31:57.858 WARN:   chromium : --------- beginning of crash
204	2018-05-18 20:31:57.862 ASSERT: libc : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x2e in tid 22807 (TaskSchedulerSi), pid 22651 (dblockplus.orca)
205	2018-05-18 20:31:57.959 INFO:   crash_dump32 : obtaining output fd from tombstoned, type: kDebuggerdTombstone
206	2018-05-18 20:31:57.960 INFO:   /system/bin/tombstoned : received crash request for pid 22651
207	2018-05-18 20:31:57.962 INFO:   crash_dump32 : performing dump of process 22651 (target tid = 22807)
208	2018-05-18 20:31:57.962 ASSERT: DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
209	2018-05-18 20:31:57.962 ASSERT: DEBUG : Build fingerprint: 'google/sailfish/sailfish:8.1.0/OPM1.171019.011/4448085:user/release-keys'
210	2018-05-18 20:31:57.962 ASSERT: DEBUG : Revision: '0'
211	2018-05-18 20:31:57.962 ASSERT: DEBUG : ABI: 'arm'
212	2018-05-18 20:31:57.962 ASSERT: DEBUG : pid: 22651, tid: 22807, name: TaskSchedulerSi  >>> org.adblockplus.orca <<<
213	2018-05-18 20:31:57.962 ASSERT: DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2e
214	2018-05-18 20:31:57.962 ASSERT: DEBUG : Cause: null pointer dereference
215	2018-05-18 20:31:57.962 ASSERT: DEBUG : r0 00000002  r1 b045e587  r2 00000012  r3 00000011
216	2018-05-18 20:31:57.962 ASSERT: DEBUG : r4 d5fa5000  r5 cb37a53c  r6 cb37a488  r7 cb37a4a0
217	2018-05-18 20:31:57.962 ASSERT: DEBUG : r8 d6c3b584  r9 cbb26728  sl d6c31374  fp 00000000
218	2018-05-18 20:31:57.962 ASSERT: DEBUG : ip d755e244  sp cb37a478  lr d75000e3  pc ceefa402  cpsr 600d0030
219	2018-05-18 20:31:57.970 ASSERT: DEBUG : backtrace:
220	2018-05-18 20:31:57.971 ASSERT: DEBUG : #00 pc 0028c402  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libchrome.cr.so
221	2018-05-18 20:31:57.971 ASSERT: DEBUG : #01 pc 00080847  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so (base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)+98)
222	2018-05-18 20:31:57.971 ASSERT: DEBUG : #02 pc 000834a5  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so (base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool)+284)
223	2018-05-18 20:31:57.971 ASSERT: DEBUG : #03 pc 000cc81f  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so (base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool)+54)
224	2018-05-18 20:31:57.971 ASSERT: DEBUG : #04 pc 000cbdab  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so (base::internal::TaskTracker::RunNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*)+106)
225	2018-05-18 20:31:57.971 ASSERT: DEBUG : #05 pc 000c970d  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so
226	2018-05-18 20:31:57.971 ASSERT: DEBUG : #06 pc 000d17c7  /data/app/org.adblockplus.orca-zlKIVBp3zcZ6XRd1CZsotQ==/lib/arm/libbase.cr.so
227	2018-05-18 20:31:57.971 ASSERT: DEBUG : #07 pc 00047ee7  /system/lib/libc.so (__pthread_start(void*)+22)
228	2018-05-18 20:31:57.971 ASSERT: DEBUG : #08 pc 0001b1d9  /system/lib/libc.so (__start_thread+32)
Last edited 17 months ago by asmirnov (previous) (diff)

comment:2 follow-up: Changed 17 months ago by asmirnov

i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d

Last edited 17 months ago by asmirnov (previous) (diff)

comment:3 in reply to: ↑ 2 ; follow-up: Changed 17 months ago by jwangenheim

Replying to asmirnov:

i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d

I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.

comment:4 in reply to: ↑ 3 ; follow-up: Changed 17 months ago by asmirnov

Replying to jwangenheim:

Replying to asmirnov:

i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d

I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.

Do you also have two-factor auth?

comment:5 in reply to: ↑ 4 Changed 17 months ago by jwangenheim

Replying to asmirnov:

Replying to jwangenheim:

Replying to asmirnov:

i can't reproduce it (having two-factor authentication, so one more step is added after typing password) with AbpChromium fbc09406b939da668ad97c1f2d9258905818ac7d

I've tried it with the AbpChromium version I've got installed on my phone (15112b7ac6c358d1026e339d1abf74054a1bdae9) and can reproduce it.

Do you also have two-factor auth?

Yes, I do.

comment:6 Changed 17 months ago by asmirnov

i've tested 15112b7ac6c358d1026e339d1abf74054a1bdae9 with two-factor auth and i can't reproduce.

Changed 17 months ago by asmirnov

no crash log for me

Changed 17 months ago by asmirnov

no crash screenshot for me

comment:7 Changed 17 months ago by asmirnov

According to the log (can see Adblock: element hiding - generated JS but no Adblock: element hiding - called JS) and the sources i can imagine that frameHost is nullptr:
https://gitlab.com/eyeo/adblockplus/chromium/blob/96ed84b4a7fcbf0b3436d186c0a8fc7ae3888c99/chrome/browser/android/adblock/adblock_bridge.cc#L163

webContents can't be nullptr as it would crash earlier:
https://gitlab.com/eyeo/adblockplus/chromium/blob/96ed84b4a7fcbf0b3436d186c0a8fc7ae3888c99/chrome/browser/android/adblock/adblock_bridge.cc#L143

So it looks like Chromium bug then..

Last edited 17 months ago by asmirnov (previous) (diff)

comment:8 Changed 7 months ago by aboegler

I'm no longer experiencing this crash with Orca 0.4.0 and 0.5.0.

Note: See TracTickets for help on using tickets.