Changes between Version 18 and Version 21 of Ticket #6690


Ignore:
Timestamp:
06/05/2018 05:14:08 AM (16 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6690

    • Property Status changed from new to closed
    • Property Resolution changed from to fixed
  • Ticket #6690 – Description

    v18 v21  
    2626- This has some implications on our code that needs to know if filter domains can ever have trailing dots. [https://codereview.adblockplus.org/29785581/ See the discussion in this codereview] for example. 
    2727- Our users have asked in the past that filters for the domain without the trailing dot should apply to requests to the domain with the trailing dot. See #4302. 
     28 
     29=== Resolution === 
     30 
     31To resolve this issue, the following changes have been made for both URL request blocking and element hiding: 
     32 
     33 1.  If a filter contains a trailing dot in the domain name, Adblock Plus does not strip the trailing dot out (i.e. in `example.com.##.foo` the domain is `example.com.`) 
     34 2.  If the domain of a document contains a trailing dot, the trailing dot is always stripped out (i.e. in `https://example.com./foo` the domain is `example.com`) 
     35 
     36As a result, filters containing a trailing dot in the domain name will no longer match the document's domain name (i.e. `example.com.##.foo` will no longer apply on either `https://example.com/foo` or `https://example.com./foo`), whereas filters containing ''no'' trailing dot in the domain name will match the document's domain name both with and without a trailing dot. 
     37 
     38Note that this does not affect the URL pattern in a blocking filter. i.e. `https://example.com/foo.js$domain=example.com` still will not block the URL `https://example.com./foo.js` no matter what the document's domain. 
     39 
     40=== Hints for testers === 
     41 
     42Test that the new behavior described in the previous section works correctly.