Changes between Version 5 and Version 6 of Ticket #6692


Ignore:
Timestamp:
05/29/2018 03:52:54 PM (19 months ago)
Author:
kzar
Comment:

Thanks, I could reproduce it more reliably this time with madeleine.de. I've managed to bisect and find the problematic commit.

Unfortunately the commit in question was attempting to work around limitations with the Chrome extension APIs we use to keep track of pages and frames, changes to this code tends to fix 2 things and break something else! Such problems are often non-trivial and involve race conditions which will only show up on certain websites or at certain times.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6692 – Description

    v5 v6  
    2525 
    2626=== Notes === 
    27 Keep in mind the ads might stop appearing even when everything works. In that case close the incognito window and start retargeting again. It could be this setup (targeting via teufel.de and ad serving on autozeitung.de) is only working in Germany but I haven't tested that.  
    28  
    29 This is working fine with ABP 3.1 btw. 
     27- Keep in mind the ads might stop appearing even when everything works. In that case close the incognito window and start targeting again. 
     28- This is a regression caused by [https://hg.adblockplus.org/adblockpluschrome/rev/1cf57a70f44b this commit 1cf57a70f44b].