Opened 16 months ago

Last modified 13 months ago

#6695 reopened change

Download recent supported version of V8 and use it for local builds by default.

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29807589/
https://codereview.adblockplus.org/29812567/

Description

Background

In the codereview there was a request to make the building and using of the library more user friendly, https://codereview.adblockplus.org/29783566/diff/29783567/README.md#newcode52 regarding binaries. Currently one has to dig through the CI scripts in order to download prebuilt V8 or build it manually (what takes a lot of time and disk space).

JIC, in order to download the versions for today one can use the following commands on linux URL_PREFIX=https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/ TARGET_OS=android Configuration=release TARGET_ARCH=arm .travis/prepare-prebuilt-v8.sh or URL_PREFIX=https://v8.eyeofiles.com/v8-4fc9a2fe7f8a7ef1e7966185b39b3b541792669a/ TRAVIS_OS_NAME=linux .travis/prepare-prebuilt-v8.sh, etc.

and get the downloaded prebuilt V8 in third_party/prebuilt-v8/.

What to change

  • Taking into account #6694, create a file with the list of supported/tested versions of V8 and use that list for CI.
  • provide a script downloading the recent version by default or a version specified in the command line arguments
  • integrate that script either into the building system or dependencies (ensure_dependencies.py or even switch to depot_tools and DEPS or check what meson can provide with).

Change History (9)

comment:1 Changed 16 months ago by hfiguiere

  • Cc hfiguiere added

comment:2 Changed 15 months ago by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed 15 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6695 - Allow automatically downloading V8

comment:5 Changed 15 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 15 months ago by sergz

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 15 months ago by sergz

  • Review URL(s) modified (diff)

comment:8 Changed 15 months ago by abpbot

comment:9 Changed 13 months ago by hfiguiere

  • Owner hfiguiere deleted
Note: See TracTickets for help on using tickets.