Opened on 05/24/2018 at 08:44:38 AM

Last modified on 09/07/2018 at 04:05:45 PM

#6695 reopened change

Download recent supported version of V8 and use it for local builds by default.

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



In the codereview there was a request to make the building and using of the library more user friendly, regarding binaries. Currently one has to dig through the CI scripts in order to download prebuilt V8 or build it manually (what takes a lot of time and disk space).

JIC, in order to download the versions for today one can use the following commands on linux URL_PREFIX= TARGET_OS=android Configuration=release TARGET_ARCH=arm .travis/ or URL_PREFIX= TRAVIS_OS_NAME=linux .travis/, etc.

and get the downloaded prebuilt V8 in third_party/prebuilt-v8/.

What to change

  • Taking into account #6694, create a file with the list of supported/tested versions of V8 and use that list for CI.
  • provide a script downloading the recent version by default or a version specified in the command line arguments
  • integrate that script either into the building system or dependencies ( or even switch to depot_tools and DEPS or check what meson can provide with).

Attachments (0)

Change History (9)

comment:1 Changed on 05/25/2018 at 03:44:47 PM by hfiguiere

  • Cc hfiguiere added

comment:2 Changed on 06/15/2018 at 01:52:20 AM by hfiguiere

  • Owner set to hfiguiere

comment:3 Changed on 06/15/2018 at 01:54:22 AM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 06/18/2018 at 04:25:09 PM by abpbot

A commit referencing this issue has landed:
Issue 6695 - Allow automatically downloading V8

comment:5 Changed on 06/18/2018 at 04:26:10 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 06/18/2018 at 08:31:00 PM by sergz

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed on 06/21/2018 at 09:25:50 AM by sergz

  • Review URL(s) modified (diff)

comment:8 Changed on 06/21/2018 at 12:00:25 PM by abpbot

comment:9 Changed on 09/07/2018 at 04:05:45 PM by hfiguiere

  • Owner hfiguiere deleted

Add Comment

Modify Ticket

Change Properties
as reopened .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.