#6701 closed change (fixed)

Implement CSP support in python-abp

Reported by: kvas Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29793573

Description (last modified by kvas)

Background

ABP now supports filters that inject a Content Security Policy via $csp option (see documentation here, implemented by #5241, #6329). Python-abp should also support this option.

What to change

Implement parsing of $csp option. Python-abp doesn't interpret the options (it does not compute the resulting resource type masks or anything like that) so $csp should simply be handled as an option with a value or, when negated (the doc doesn't mention this, but there's a test for it in abpcore tests), it should get the value of False.

Notes:

  • Filter normalization is not part of this ticket.

References:

Change History (5)

comment:1 Changed 19 months ago by kvas

  • Description modified (diff)

comment:2 Changed 19 months ago by rhowell

  • Owner set to rhowell
  • Ready set
  • Review URL(s) modified (diff)

comment:3 Changed 19 months ago by kvas

  • Priority changed from Unknown to P3
  • Status changed from new to reviewing

comment:4 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 6701 - Implement CSP support in python-abp

comment:5 Changed 18 months ago by rhowell

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.