#6707 closed change (fixed)

Make the generated malware domain filter list encode domains as Punycode

Reported by: sebastian Assignee: atudor
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, tlucas, sebastian, atudor Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29821558/

Description

Background

Since #6647 (also see the related devbuild announcement), we expect domains in filters being encoded as Punycode (instead of Unicode). However, the generated malware domain list still encodes domains as Unicode. Hence any filter containing an internationalized domain in the malware domain list won't have any effect in Adblock Plus 3.2 (and above).

What to change

Make the generated malware domain filter list encode domains as Punycode.

Change History (6)

comment:1 Changed 18 months ago by kvas

  • Cc sebastian added
  • Priority changed from Unknown to P2
  • Ready set

@sebastian: are there any timing requirements for this issue? Namely, does it have to be deployed together with ABP 3.2 (which would be the case if ABP currently doesn't understand Punycode) or can it be deployed as soon as done?

comment:2 Changed 18 months ago by sebastian

Yeah, before Adblock 3.2, filters with domains given in Punycode won't have any effect, while starting with Adblock Plus 3.2, filters with internationalized domains in Unicode won't have any effect.

So if this change would be deployed close to the Adblock Plus 3.2 release, this would minimize scenarios in which filters don't work as expected. But IMO its not important enough to justify any hassle making sure this change gets deployed at the day of the release.

comment:3 Changed 17 months ago by atudor

  • Cc atudor added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 17 months ago by tlucas

  • Owner set to atudor

comment:6 Changed 17 months ago by atudor

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.