Opened 19 months ago

Closed 19 months ago

Last modified 17 months ago

#6708 closed change (fixed)

Update adblockplusui dependencies to f6cbede1b008

Reported by: saroyanm Assignee: saroyanm
Priority: P1 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: greiner, wspee, agiammarchi, sebastian, kzar, hfiguiere, Shikitita, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29794577/

Description (last modified by kzar)

Background

Those are changes Adblock Plus UI team wish to add to the release.

What to change

  • Update adblockplusui dependency to hg:f6cbede1b008 git:1c660ba

Changes since last adblockplusui dependency update

Ticket Summary Component
#6705 Stop creating email field on validation [issue reporter] User-Interface
#6703 Import remaining translations from the Crowdin User-Interface
#6702 Import priority translations from the Crowdin User-Interface
#6697 Use common_notification_hide intead options_notification_hide and issueReporter_notification_hide User-Interface
#6696 Import translations for the release-2018-2 User-Interface
#6670 Log URL rewrites in DevTools User-Interface
#6662 Add `locale` format in the messaging API documentation User-Interface
#6661 Localize date in the Filter Lists section of options page User-Interface
#6658 Update tooltip for privacy feature in options page User-Interface
#6532 Remove subscription title input field when adding filterlists by url User-Interface
#6514 IOToggle Custom Element User-Interface
#6386 Add Requests and Filters data to the Report data [Issue reporter] User-Interface


Additional changes

Hints for testers

  • Ensure that the requests and filter hits are added into the report, also ensure that email is being submitted only once and when Anonymous submission is checked, no email is added into the report(#6386, #6705)
  • "Close notification" hidden(for screen readers) text is being shown when inspecting close button of Issue reporter top notification and Whitelisted website notification button(#6697)
  • Date of the filter list in the Filter Lists section of the Advanced Tab(options page) is using localized regional format instead of (D/M/Y) format (#6661)
  • No Filter Title exist when adding Filter List from the Advanced Tab with "Add new filter list" button, but filter list title exist when adding using ABP Subscription link(#6532)
  • Easy privacy tooltip is using new text(#6658)

Change History (17)

comment:1 Changed 19 months ago by saroyanm

  • Description modified (diff)

comment:2 Changed 19 months ago by saroyanm

  • Cc greiner wspee agiammarchi added
  • Description modified (diff)

comment:3 follow-up: Changed 19 months ago by saroyanm

@Andrea, @Thomas Can you please update Hints for testers section with the information if applicable. AFAIK IOToggle Custom Element is not used on any page, but some smoke tests are implemented, I'm not sure if that's something that worth mentioning, because it's not part of the any existing page yet ? Anyway please update if you think I've missed something.

Currently I'm waiting for the translations reviews to be ready, then I can merge with the Mercurial Master branch and have actual dependency hash ready for finalizing current ticket.

comment:4 in reply to: ↑ 3 Changed 19 months ago by agiammarchi

Replying to saroyanm:

AFAIK IOToggle Custom Element is not used on any page

exactly, so there's nothing to rush/hint about it so far, it was the most basic component used to bring in the latest custom elements based architecture, everything will be documented once used ;-)

comment:5 Changed 19 months ago by saroyanm

  • Cc sebastian kzar added

@Dave, @Sebastian: I'm waiting for Tamara to finish the Crowdin import review, after that I'll update this issue with the HASH, as soon I get a go I'll make all the change and make this issue ready today.

comment:6 Changed 19 months ago by hfiguiere

  • Cc hfiguiere added

comment:7 Changed 19 months ago by kzar

  • Cc Shikitita added
  • Component changed from Unknown to Platform
  • Priority changed from Unknown to P1

Replying to saroyanm:

@Dave, @Sebastian: I'm waiting for Tamara to finish the Crowdin import review, after that I'll update this issue with the HASH, as soon I get a go I'll make all the change and make this issue ready today.

This is now the last thing that we need to do before beginning QA for the release, so I've marked this as P1. We were aiming to land everything necessary today, how realistic is it that we'll manage to update the adblockplusui dependency today?

comment:8 Changed 19 months ago by kzar

  • Cc Ross added

comment:9 Changed 19 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:10 Changed 19 months ago by saroyanm

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependencies to {Number} to Update adblockplusui dependencies to f6cbede1b008

comment:11 Changed 19 months ago by saroyanm

  • Review URL(s) modified (diff)

@Kzar, @Sebastian: I think this ticket can be made ready.

I also attached a review.

Thanks for waiting with the release so we could also prepare all translations for it.

comment:12 Changed 19 months ago by saroyanm

  • Description modified (diff)

Added also remaining issues about importing the translations back from the crowdin.

comment:13 Changed 19 months ago by kzar

  • Owner set to saroyanm
  • Ready set

comment:14 Changed 19 months ago by kzar

  • Description modified (diff)

comment:15 Changed 19 months ago by saroyanm

Commit landed, unfortunately, I used wrong Issue number in the commit, sorry:

https://hg.adblockplus.org/adblockpluschrome/rev/0d0852f901f3

comment:16 Changed 19 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

comment:17 Changed 17 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. The related child tickets appear to be working as expected.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

Note: See TracTickets for help on using tickets.