Opened on 05/31/2018 at 08:01:30 PM

Closed on 06/01/2018 at 11:35:03 AM

Last modified on 07/05/2018 at 12:38:26 PM

#6715 closed defect (fixed)

The adblockpluschrome unit tests are failing

Reported by: hfiguiere Assignee: hfiguiere
Priority: P1 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian, Ross Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


Adblock Plus master 3.2 (code freeze) (rev 7122a201b554) on Chrome.

How to reproduce

  1. build the devenv for Chrome
  2. load the extension in Chrome
  3. Run the qunit test:
    1. open the option page
    2. In the JS console enter location.href = "qunit/index.html";

Observed behaviour

Test show failure (missing getDecodedHostname() and stringifyURL(); punycode in URL).

Expected behaviour

All test pass.


  • Not tested on Firefox. I don't think it matters.
  • This is related to issue #6647: we removed the missing functions and we no longer convert URLs with Unicode.

Hints for testers

No need to test this one, it's just a change to the unit tests which aren't included in the release.

Attachments (0)

Change History (7)

comment:1 Changed on 05/31/2018 at 08:32:20 PM by hfiguiere

  • Review URL(s) modified (diff)

comment:2 Changed on 05/31/2018 at 08:32:26 PM by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed on 06/01/2018 at 12:57:20 AM by hfiguiere

  • Description modified (diff)

comment:4 Changed on 06/01/2018 at 09:48:50 AM by kzar

  • Cc kzar sebastian Ross added
  • Component changed from Adblock-Plus-for-Chromium to Platform
  • Description modified (diff)
  • Milestone set to Adblock-Plus-3.2-for-Chrome-Opera-Firefox
  • Priority changed from Unknown to P1
  • Ready set
  • Summary changed from WebExtension qunit tests fail to The adblockpluschrome unit tests are failing

comment:5 Changed on 06/01/2018 at 11:33:58 AM by abpbot

A commit referencing this issue has landed:
Issue 6715 - Fix the url qunit tests.

comment:6 Changed on 06/01/2018 at 11:35:03 AM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 07/05/2018 at 12:38:26 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

These pass again.

adblockpluschrome / master / 2069:56f54c897e3a
Chrome 67 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.