Opened 8 months ago

Last modified 7 months ago

#6716 new change

Ignore resource: protocol in Firefox

Reported by: tschuster Assignee: tschuster
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

We already ignore the moz-extension and chrome protocol, I think for good measure we should also block resource:, which was mostly used for old style extensions, but also by Firefox code. I think maybe devtools stuff could be relevant here.

https://hg.adblockplus.org/adblockpluschrome/file/7122a201b554/lib/requestBlocker.js#l162

Change History (3)

comment:1 Changed 8 months ago by sebastian

  • Cc sebastian added
  • Milestone Adblock-Plus-3.2-for-Chrome-Opera-Firefox deleted

Sounds reasonable, assuming you verified that requests with resource: protocol are recorded by the webRequest API under some circumstances (and show up in the Adblock Plus devtools panel)?

comment:2 Changed 7 months ago by tschuster

Actually I check and add-ons don't receive events for resource: origins with onBeforeRequest. Neither however do they receive those for chrome:. As far as I can tell we added this check with https://hg.adblockplus.org/adblockpluschrome/diff/32abf77e231a/ext/background.js, which is not a helpful revision.

comment:3 Changed 7 months ago by sebastian

Interesting. So this means this issue can be closed, and we can remove the logic checking for an originUrl with chrome: protocol? Sounds good, feel free to do that.

Note: See TracTickets for help on using tickets.