Opened 18 months ago

Closed 16 months ago

Last modified 14 months ago

#6717 closed change (fixed)

Run tests in adblockpluschrome using npm

Reported by: hfiguiere Assignee: tlucas
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By: #6881
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29808587/
https://codereview.adblockplus.org/29860555/

Description (last modified by tlucas)

Background

Currently running the qunit tests in adblockpluschrome involve:

  1. building a devenv build
  2. loading it into the browser (reload is automatic and Chrome remembers if it was load in the previous session)
  3. opening the option page (in Chrome it gets closed when the addon is reloaded)
  4. opening the dev tools
  5. entering location.href = "qunit/index.html"; in the javascript console.

Ideally we should just be able to do npm test to run the tests.

What to change

  • add a package.json
  • add a test target in the package.json that will perform the devenv build and run the tests
    • This involves adding WebDriver support like in issue #6391, use adblockpluscores implementation for downloading Firefox when necessary. Hence #6881 needs to land before this change.

Note for tester

  • Nothing to do, it doesn't impact the release.

Change History (15)

comment:1 Changed 18 months ago by kzar

  • Component changed from Adblock-Plus-for-Chromium to Platform

comment:2 Changed 18 months ago by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:3 Changed 18 months ago by hfiguiere

  • Status changed from new to reviewing

comment:4 Changed 17 months ago by kzar

  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 6717 - Part 1: run eslint through npm

comment:6 Changed 16 months ago by tlucas

  • Owner changed from hfiguiere to tlucas

comment:7 Changed 16 months ago by tlucas

  • Review URL(s) modified (diff)

comment:8 Changed 16 months ago by tlucas

  • Description modified (diff)

comment:9 Changed 16 months ago by tlucas

  • Blocked By 6881 added

comment:10 Changed 16 months ago by tlucas

  • Blocked By 6881 removed
  • Description modified (diff)

comment:11 Changed 16 months ago by tlucas

  • Blocked By 6881 added

comment:12 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 6717 - Part 2: run qunit in headless firefox

comment:13 Changed 16 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 16 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:15 Changed 14 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done/Implemented. Working as expected on Linux and Windows. Can run both automated tests and qunit tests using npm test.

adblockpluschrome / master / 2164:856217ee8673

Note: See TracTickets for help on using tickets.