Changes between Version 2 and Version 3 of Ticket #6720


Ignore:
Timestamp:
06/01/2018 06:06:20 PM (18 months ago)
Author:
hfiguiere
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6720 – Description

    v2 v3  
    11=== Environment === 
    2 With `adblockpluschrome` master (rev 9dd0a8081209), the qunit test are packaged in the extension archive file. 
     2With `adblockpluschrome` master (rev 9dd0a8081209), the qunit tests are packaged in the extension archive file. 
    33 
    44=== How to reproduce === 
     
    66 
    77=== Observed behaviour === 
    8 If you look at the content of the respective archives, using `unzip -l`, list the content. Both `qunit/tests.js` and `qunit/tests.js.map` are packaged 
     8Look at the content of the respective archives: using `unzip -l`, list the content. Both `qunit/tests.js` and `qunit/tests.js.map` are packaged. 
    99 
    1010=== Expected behaviour === 
    11 I'd expect they are not packaged. 
     11I'd expect them to not be packaged. 
    1212 
    1313=== Analysis === 
    14 In `buildtools/packagerChrome.py` in the `create_bundles` it create the `qunit/tests.js` bundlein the webpack configuration unconditionally, based on the manifest, then again if `bundle_tests` is true, adds another bundle in the webpack configuration, by list the directory content. 
     14In `buildtools/packagerChrome.py`, the `create_bundles` function creates the `qunit/tests.js` bundle for the webpack configuration, unconditionally, based on the manifest file. Then again, if `bundle_tests` is true, it adds another bundle in the webpack configuration, by listing the `qunit/tests` directory content. 
    1515 
    1616=== Notes for testers ===