Opened 17 months ago

Closed 17 months ago

Last modified 7 months ago

#6723 closed change (fixed)

Adjust branding directory

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.5.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29796630/

Description

There have been some changes in the required branding files since the adblockbrowser branding directory was created. Some files are required now (e.g. drawable-nodpi/firstrun_welcome.png), other files that are there aren't required anymore (e.g. drawable-hdpi/widget_icon.png). We need to adjust our branding directory accordingly. The official branding directory might be used as reference.

Change History (8)

comment:1 Changed 17 months ago by diegocarloslima

  • Ready set

comment:2 Changed 17 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 6723 - Adjust branding directory

comment:4 Changed 17 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 14 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next

comment:6 Changed 7 months ago by aboegler

Are there any particular locations where these new icons are used, and that need to be tested?

comment:7 Changed 7 months ago by diegocarloslima

Currently, there are 3 different resources in the branding directory:

  • firstrun_welcome: was supposed to be used in the first run slides, but since we use our own onboarding slides, its not used. Its just there to avoid potential build errors
  • icon: is used in several places around the app. The easiest way to verify that the icon resource being used is our own is to check the app icon
  • large_icon: looks like this one is not used in the mobile app. But also, its there to avoid any build issues and to be in the safe side of not showing any firefox icon by accident

comment:8 Changed 7 months ago by aboegler

Thanks Diego!

QA LGTM.

Note: See TracTickets for help on using tickets.