Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#6735 closed change (fixed)

Store domains in lower case

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords:
Cc: sergz, kzar Blocked By:
Blocking: #7000 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)


Domain names are typically represented in lower case, both in filter lists and as reported by the browser. But the filter classes store the domain names in upper case. The conversion from lower case to upper case creates an additional string that would not otherwise be necessary.

According to my tests, if the filter classes store domain names in lower case instead, it saves ~2 MB on the JS heap with the default subscriptions.

What to change

In the RegExpFilter.fromText implementation, convert the value of the domain option to lower case rather than upper case. Update the names of related properties and the documentation accordingly.

Hints for testers

Test that filters with upper case or mixed case domains work correctly. For example,, should apply on but not on

Change History (8)

comment:1 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by mjethani

  • Priority changed from Unknown to P2
  • Ready set
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6735 - Store domains in lower case

comment:4 Changed 2 years ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by mjethani

  • Description modified (diff)

comment:6 Changed 2 years ago by mjethani

  • Description modified (diff)

comment:7 Changed 23 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working as described.

Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

comment:8 Changed 22 months ago by mjethani

  • Blocking 7000 added
Note: See TracTickets for help on using tickets.