Opened 12 days ago

Last modified 6 days ago

#6739 new change

Update code to work with FilterStorage.knownSubscriptions as a Map object

Reported by: mjethani Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner, saroyanm, agiammarchi, wspee Blocked By: #6559
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

FilterStorage.knownSubscriptions is now a Map object (changeset 212fe705ab82).

What to change

Modify any code that assumes the type of FilterStorage.knownSubscriptions to be Object, treat it as a Map object now (e.g. use Map.has instead of the in operator).

Hints for testers

  • Removing a filter list should still work
  • En-/disabling a filter list should still work
  • Anti-adblock notification should still work (even after the anti-adblock filter list receives an update)

Change History (3)

comment:1 Changed 12 days ago by greiner

  • Cc agiammarchi wspee added
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Thanks for the heads-up. Note that the adblockpluscore dependency is defined by adblockpluschrome so I've removed the dependency update part of the change.

comment:2 Changed 7 days ago by greiner

  • Description modified (diff)
  • Owner set to greiner

comment:3 Changed 6 days ago by greiner

  • Blocked By 6559 added
Note: See TracTickets for help on using tickets.