Opened 2 months ago

Closed 4 weeks ago

#6739 closed change (fixed)

Update code to work with FilterStorage.knownSubscriptions as a Map object

Reported by: mjethani Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner, saroyanm, agiammarchi, wspee Blocked By:
Blocking: #6753 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

FilterStorage.knownSubscriptions is now a Map object (changeset 212fe705ab82).

What to change

Modify any code that assumes the type of FilterStorage.knownSubscriptions to be Object, treat it as a Map object now (e.g. use Map.has instead of the in operator).

Hints for testers

  • Removing a filter list should still work
  • En-/disabling a filter list should still work
  • Anti-adblock notification should still work (even after the anti-adblock filter list receives an update)

Change History (7)

comment:1 Changed 2 months ago by greiner

  • Cc agiammarchi wspee added
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Thanks for the heads-up. Note that the adblockpluscore dependency is defined by adblockpluschrome so I've removed the dependency update part of the change.

comment:2 Changed 2 months ago by greiner

  • Description modified (diff)
  • Owner set to greiner

comment:3 Changed 2 months ago by greiner

  • Blocked By 6559 added

comment:4 Changed 8 weeks ago by wspee

  • Blocking 6753 added

comment:5 Changed 5 weeks ago by greiner

Done: https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/93e8b26e725870e4aa2fd09ea470a2bf5ac18f08

Keeping this ticket open since it requires #6559 before it can be used in Platform.

comment:7 Changed 4 weeks ago by greiner

  • Blocked By 6559 removed
  • Resolution set to fixed
  • Status changed from new to closed

Removing blocker and closing ticket since the adblockpluscore dependency will be ensured by #6753.

Note: See TracTickets for help on using tickets.