Opened 17 months ago

Closed 2 months ago

#6741 closed change (rejected)

Use ECMAScript 2015 classes

Reported by: mjethani Assignee: mjethani
Priority: P4 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: sergz, kzar, jsonesen Blocked By: #7001
Blocking: #6482 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29803559/
https://codereview.adblockplus.org/29855595/
https://codereview.adblockplus.org/29859558/
https://codereview.adblockplus.org/29859565/
https://codereview.adblockplus.org/29869571/

Description (last modified by mjethani)

Background

See #6482.

What to change

Convert "classes" everywhere in the Core module to ES 2015 classes, and update the JSDoc comments accordingly to remove redundant @constructor and similar tags.

Hints for testers

The changes until changeset 4520c259dbcf should have no impact on current behavior. Make sure that filter list downloads and element hiding emulation work as expected in general (no specific recommendations).

For the dependency update in #6933, there are no specific things to test as there is no change in behavior or implementation details.

Change History (17)

comment:1 Changed 17 months ago by mjethani

  • Priority changed from P3 to P4

comment:2 Changed 17 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 15 months ago by jsonesen

  • Review URL(s) modified (diff)

comment:4 Changed 15 months ago by jsonesen

  • Cc jsonesen added

comment:5 Changed 15 months ago by mjethani

  • Review URL(s) modified (diff)

comment:6 Changed 15 months ago by abpbot

comment:7 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/events.js

comment:8 Changed 15 months ago by jsonesen

  • Review URL(s) modified (diff)

comment:9 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/downloader.js

comment:10 Changed 15 months ago by mjethani

  • Description modified (diff)

comment:11 Changed 15 months ago by jsonesen

  • Review URL(s) modified (diff)

comment:12 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/synchronizer.js

comment:13 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 6741 - Use ES2015 classes in lib/matcher.js

comment:14 Changed 14 months ago by mjethani

  • Description modified (diff)

comment:15 Changed 14 months ago by mjethani

  • Blocked By 7001 added

comment:16 Changed 13 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Element hiding emulation is still working as expected.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

comment:17 Changed 2 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.