Opened 18 months ago

Closed 8 months ago

Last modified 7 months ago

#6765 closed defect (rejected)

No COPYING file in the root directory

Reported by: dr_boo Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: Kai, sebastian, greiner, mjethani Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/110

Description (last modified by mapx)

GNU General Public License, version 3.0"

  • "Add a COPYING file with a copy of the GNU GPL or GNU AGPL." -

https://www.gnu.org/licenses/gpl-howto.html

  • The latest release (at this writing)

https://addons.mozilla.org/firefox/downloads/file/957947/adblock_plus-3.1-an+fx.xpi doesn't contain a copy of the GNU GPL 3.0 license in the root directory.

place the file in the root directory for Adblock Plus?

Change History (11)

comment:2 Changed 18 months ago by mapx

  • Description modified (diff)

comment:3 Changed 18 months ago by greiner

  • Cc Kai sebastian greiner added
  • Component changed from Unknown to Platform

We do include a COPYING file in both hg.adblocklus.org/adblockplus as well as hg.adblockplus.org/adblockpluschrome. It seems that neither of those includes this file in the extension bundle though.

comment:4 Changed 15 months ago by sebastian

As far as I understand (please correct me if I'm wrong Kai), there is no need to bundle a copy of the license with the build. It's generated code anyway, not the source code that is subject to the license, and the license is stated on the AMO page.

comment:5 Changed 14 months ago by greiner

  • Blocking 6936 added
  • Review URL(s) modified (diff)

As part of this change we've added a COPYING file to adblockplusui in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/93fa6916fbb0faabbab5ba87b1c161eec941e92d.

Whether or not the file should be included in the extension build seems to be up to Kai to decide then.

comment:6 Changed 8 months ago by mjethani

  • Cc mjethani added

comment:7 Changed 8 months ago by Kai

No need to bundle it with the extension build. Only with the source code. But if its not a big hassle to ad the COPYING file to the extension bundle, then you should do it anyway to increase transparency.

comment:8 Changed 8 months ago by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

comment:9 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 6765 - Added COPYING file

comment:10 Changed 7 months ago by kzar

  • Blocking 6936 removed

comment:11 Changed 7 months ago by kzar

  • Blocking 6936 added
Note: See TracTickets for help on using tickets.