#6774 closed defect (fixed)

$document doesn't whitelist everything inside iframes in Edge

Reported by: oleksandr Assignee: geo
Priority: Unknown Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, geo, arthur Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29832561/

Description (last modified by mapx)

Environment

ABP for Edge 0.9.11

How to reproduce

  1. Add this custom filter: @@^uponit=true$document
  2. Set up attached files in one directory
    • Load SafeFrame.html - a simple html file with a static ad.
    • Include_safeFrame.html is a simple HTML file that includes the first one with the parameter uponit=true while this rule exists:

@@^uponit=true$document

  1. Open Include_safeFrame.html in Edge.

Observed behaviour

The requests inside safeFrame.html are indeed white-listed, but the ad is hidden by a CSS selector, and the result is a blank ad.

Expected behaviour

The $document rule should white-list the entire iframe, but it seems that in Edge, only the requests are white-listed and the hide rules (CSS display important rules) are still there in those white-listed iframes when there is another iframe inside them.

This seems very much alike #6692, but is Edge specific.

Attachments (2)

include_safeFrame.html (75 bytes) - added by oleksandr 14 months ago.
safeFrame.html (679 bytes) - added by oleksandr 14 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 15 months ago by mapx

  • Description modified (diff)

comment:2 Changed 15 months ago by sebastian

  • Cc sebastian geo added

Changed 14 months ago by oleksandr

Changed 14 months ago by oleksandr

comment:3 Changed 14 months ago by arthur

  • Cc arthur added

comment:4 Changed 14 months ago by geo

  • Owner set to geo

comment:5 Changed 14 months ago by geo

  • Review URL(s) modified (diff)

For reproducing the bug, I recommend to serve the files from a local server, otherwise you run into CORS errors.

comment:6 Changed 14 months ago by sebastian

  • Status changed from new to reviewing

comment:7 Changed 14 months ago by abpbot

comment:8 Changed 12 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.