Opened 17 months ago

Last modified 16 months ago

#6784 closed change

Upgrade adblockplus core for anti-circumvention and snippets hg:bec7c35902d3 — at Version 14

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: mjethani, sebastian, kzar, saroyanm, wspee, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29833597/

Description (last modified by hfiguiere)

Background

To bring both the anti-circumvention list and the snippets we should upgrade the dependency on adblockplus core to hg:bec7c35902d3

Also we must update adblockplusui to hg:9a652397b9af for a dependency between #6559 and #6739.

Here are the changes for adblockpluscore:

  • Issue #6690 - Always ignore trailing dot in document domain
  • Issue #6737 - Use String.includes instead of String.indexOf
  • Issue #6559 - Use Map object for known subscriptions
  • Issue #6559 - Change SpecialSubscription.defaultsMap to Map object
  • Issue #6735 - Store domains in lower case
  • Issue #6619 - Qualify CSS selectors in document style sheet correctly
  • Issue #6727 - Use string rather than map for single-domain filters
  • Issue #6437 - Skip elements not affected by DOM mutations
  • Issue #6689 - Add type property to Subscription class
  • Issue #6689 - Added anti-CV filter list subscription
  • Issue #6538, #6781 - Add snippets
  • Issue #6733 - Allow empty values in filter options

Here is the change for adblockplusui:

  • Issue #6739 - Adapted code to work with Map implementation of FilterStorage.knownSubscriptions

What to change

Update the dependencies file to pull adblockpluscore hg:bec7c35902d3, and adblockplusui hg:9a652397b9af

Hint for testers

TBD (a lot of things)

Change History (14)

comment:1 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 17 months ago by hfiguiere

  • Description modified (diff)
  • Summary changed from Upgrade adblockplus core for anti-circumvention and snippets (rev TBD) to Upgrade adblockplus core for anti-circumvention and snippets hg:ba2fb17a1dc1

comment:3 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:4 Changed 17 months ago by hfiguiere

We need to update adblockplusui at the same time to get https://issues.adblockplus.org/ticket/6739 that is required.

comment:5 Changed 17 months ago by sebastian

  • Cc saroyanm wspee added

I discussed that with Winsley before. Right after the 3.2 release, #6739 (and only this change) will be merged in the adblockplusui Mercurial repository (they do their development on GitLab and only merge stuff to Mercurial for us to integrate). Then we can update adblockpluscore to the latest revision, and simultaneously update the adblockplusui dependency without pulling in unrelated UI changes at the same time, while not breaking anytinhg (hopefully).

For reference, #6739 (in adblockplusui) and #6559 (in adblockpluscore) have a mutual depdency, i.e. if those changes aren't pulled in simultaneously things will break.

comment:6 Changed 17 months ago by wspee

  • Cc greiner added

comment:7 Changed 17 months ago by hfiguiere

  • Description modified (diff)
  • Summary changed from Upgrade adblockplus core for anti-circumvention and snippets hg:ba2fb17a1dc1 to Upgrade adblockplus core for anti-circumvention and snippets hg:5f851931ffea

comment:8 Changed 17 months ago by hfiguiere

  • Description modified (diff)
  • Summary changed from Upgrade adblockplus core for anti-circumvention and snippets hg:5f851931ffea to Upgrade adblockplus core for anti-circumvention and snippets hg:bec7c35902d3

comment:9 Changed 17 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed 17 months ago by hfiguiere

  • Owner set to hfiguiere

comment:11 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:12 Changed 17 months ago by greiner

See also duplicate ticket #6753.

comment:13 Changed 17 months ago by hfiguiere

I looked for one before even filing this one :-(

comment:14 Changed 17 months ago by hfiguiere

  • Description modified (diff)
Note: See TracTickets for help on using tickets.