Opened 2 years ago

Last modified 2 years ago

#6786 closed change

Disablay Safari app extension migration page — at Version 2

Reported by: kzar Assignee:
Priority: P2 Milestone: Adblock-Plus-1.12.5-for-Safari
Module: Platform Keywords:
Cc: sebastian, mario, l.ursachi@…, fhd, CraftyDeano, dzhang, Ross, rscott Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29829611/
https://codereview.adblockplus.org/29829615/
https://codereview.adblockplus.org/29830555/

Description (last modified by kzar)

Background

From Apple's recent announcement it seems that we will need to migrate our Adblock Plus for Safari users over to an Safari App extension as soon as possible:

# Safari Extensions
- Deprecated .safariextz-style Safari Extensions
  - Support for .safariextz-style Safari Extensions installed from the Safari Extensions Gallery is deprecated with Safari 12 on macOS. Submissions to the Safari Extensions Gallery will no longer be accepted after December 2018. Developers are encouraged to transition to Safari App Extensions.
- Disabled canLoad Safari Extensions on first launch
  - Safari Extensions that make use of the canLoad event will be disabled on first launch and users will be notified with a warning that their use is harmful to performance. These extensions can be enabled in Safari Extensions preferences. Developers are encouraged to move to Content Blocker Extensions.
- Removed Support for Developer-signed .safariextz Safari Extensions
  - Support for developer-signed .safariextz Safari Extensions in Safari 12 on macOS has been removed. They no longer appear in Safari preferences and cannot be enabled. On first launch users will receive a warning notification and these extension will not load.

So, we'd like to create a "Please migrate to our Safari App extension" page and have the Safari extension open it when the extension starts. Since that page is not yet ready, we'd also like to first check that the page exists before opening it.

What to change

  • For users on Safari 10 and above...
    • When the extension starts perform a request in the background to https://adblockplus.org/safari-app-extension-migration.
      • If the response is successful open a new tab displaying that page.
      • If not retry in 24 hours time.

Change History (2)

comment:1 Changed 2 years ago by kzar

Some questions:

  • Should we display the page when the extension starts, and every 24 hours afterwards, or just once the extension starts?
  • Should we care to store a preference that the background request has succeeded in the past? That way we could avoid performing as many requests in the background to the page, but at the cost of adding complexity.
  • Is the URL and are the other details OK?

comment:2 Changed 2 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.