Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#6787 closed change (fixed)

Apply rewrite filter even if the rewrite URL is blank

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29828591/

Description (last modified by mjethani)

Background

With #6733 we now support blank values in the $rewrite option. We should add support for blank values in the web extension as well.

What to change

In lib/requestBlocker.js, check for filter.rewrite != null rather than just filter.rewrite.

Hints for testers

The $rewrite option should work as before even after this change.

Note that a blank value cannot be set in the $rewrite option until there is a dependency update for adblockpluscore, which is not part of this issue.

Change History (9)

comment:1 Changed 3 months ago by mjethani

  • Cc sebastian kzar hfiguiere added

comment:2 Changed 3 months ago by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed 3 months ago by kzar

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 6787 - Apply rewrite filter even if the rewrite URL is blank

comment:5 Changed 3 months ago by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 3 months ago by mjethani

  • Owner set to mjethani

comment:7 Changed 3 months ago by mjethani

  • Description modified (diff)

comment:8 Changed 2 months ago by Ross

This does not seem to work in Chrome. See #6733#comment:19

comment:9 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This is working as described.

ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

Note: See TracTickets for help on using tickets.