Opened on 07/12/2018 at 11:30:37 AM

Closed on 07/12/2018 at 01:07:20 PM

Last modified on 08/20/2018 at 01:51:40 PM

#6787 closed change (fixed)

Apply rewrite filter even if the rewrite URL is blank

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)


With #6733 we now support blank values in the $rewrite option. We should add support for blank values in the web extension as well.

What to change

In lib/requestBlocker.js, check for filter.rewrite != null rather than just filter.rewrite.

Hints for testers

The $rewrite option should work as before even after this change.

Note that a blank value cannot be set in the $rewrite option until there is a dependency update for adblockpluscore, which is not part of this issue.

Attachments (0)

Change History (9)

comment:1 Changed on 07/12/2018 at 11:31:06 AM by mjethani

  • Cc sebastian kzar hfiguiere added

comment:2 Changed on 07/12/2018 at 11:39:40 AM by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed on 07/12/2018 at 12:02:52 PM by kzar

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed on 07/12/2018 at 01:02:59 PM by abpbot

A commit referencing this issue has landed:
Issue 6787 - Apply rewrite filter even if the rewrite URL is blank

comment:5 Changed on 07/12/2018 at 01:07:20 PM by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed on 07/12/2018 at 01:07:27 PM by mjethani

  • Owner set to mjethani

comment:7 Changed on 07/12/2018 at 01:10:04 PM by mjethani

  • Description modified (diff)

comment:8 Changed on 08/17/2018 at 10:53:15 AM by Ross

This does not seem to work in Chrome. See #6733#comment:19

comment:9 Changed on 08/20/2018 at 01:51:40 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

This is working as described.

Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from mjethani.
Note: See TracTickets for help on using tickets.